User "Aaron Schulz" changed the status of MediaWiki.r87781. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r87781. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87781#c18528 Commit summary: (bug 28887) Do not re-use special page objects. This causes bugs where if you do {{special:recentchanges/3}} and {{special:recentchanges/15}} the first one is used for both since the property is stored in a member variable of the class, which is then saved. MediaWiki seems to have reused the special page classes since forever. I'm not sure why. I can't imagine anyone relying on this behaviour, and it seems rather unexpected behaviour. Comment: It's still being recycled for the <code>is_array( $rec )</code> case. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
