User "MarkAHershberger" posted a comment on MediaWiki.r85497.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85497#c18553
Commit summary:
Patch from Bug #28406:
# the digitClass join versions were inverted: for a maxLength > 1 it should
be
(|||), not []
# the regexp escape for digits in the ts_number_transform_table was a bit,
er,
strange. Although it worked, I think my version is more common.
# most important: As recommended in
http://en.wikipedia.org/wiki/Percent_sign,
there may be some whitespaces between the number and the
"%". See also Bug #15422 for that, I'm not sure wheter it's
included there.
I didn't include the “non-breaking space is part of \s” bit since I didn't want
to mess up browser bug work-arounds
Comment:
fair enough.
/me grumps about code he commits for others being marked FIXME
Guess that is reason enough for me to spread commit privs far and wide ;)
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
