On Wed, Jun 22, 2011 at 1:27 PM, Brion Vibber <[email protected]> wrote:
> [snip] > The ascending sort by name usually works, but if called twice on two > tables, the second table usually gets sorted *completely* incorrectly. This > can be easily confirmed by manual inspection by copying a page such as > http://test.wikipedia.org/wiki/Planets_of_doom to your trunk wiki and > sorting first one table, then the other. > > Numeric sorting on the radius column is also incorrect; the data set > includes values with two different orders of magnitude (> 10k and < 10k), > and they don't sort correctly. You can confirm on the test.wikipedia page > that these sort as expected in 1.17. > Awesome -- diebuche tracked those bugs down to the merge sort implementation and has just fixed it in r90612. The basic sort tests now run clean! I've marked r90612 for needing merge to 1.18 so we'll be good on branch; we'll still need more test cases to confirm fix of past known table sorting bugs so everybody, do feel free to help add those. :) Big thanks to everybody who's helped in getting the test systems running and the table code improved and fixed! -- brion _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
