User "Nikerabbit" posted a comment on MediaWiki.r90650.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90650#c18595
Commit summary:
new version 1.6.3; adds edit count of fromUser to toUser; move; redirects user
page of fromUser to toUser, if this does not exist or is empty; deletes
fromUser page if toUser page exists; code contributed by Matthew April. small
changes and checked by committer
Comment:
This is remnant from PHP4 time, don't use =& but just =.
$dbw =& wfGetDB( DB_MASTER );
You can use selectField.
$result = $dbw->select( 'user', array('user_editcount'), 'user_id
='.$olduserID );
$row = $dbw->fetchRow($result);
Use array( 'user_id' => $newUserID ), it will do escaping for you.
'user_id ='.$newuserID
Message output should be html escaped or parsed:
$wgOut->addHTML(wfMsgForContent('usermerge-editcount-success', $olduserID,
$newuserID) . "<br />\n");
escapeLike is deprecated, use buildLike and anyString.
$dbr->addQuotes( $dbr->escapeLike( $oldusername->getDBkey() ) . '/%' ) .
Don't use fetchObject, use foreach ( $pages as $row )
while ( $row = $dbr->fetchObject( $pages ) ) {
I'd prefer strict === comparison here
if( $newuser_text == "Anonymous" ) { # delete ALL old pages
Must be new Article( $oldPage, 0 )
$oldPageArticle = new Article($oldPage);
makeKnownLinkObj is deprecated, use link or linkKnown
$oldLink = $skin->makeKnownLinkObj( $oldPage );
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
