User "Nikerabbit" posted a comment on MediaWiki.r90710.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90710#c18662
Commit summary:

major changes to make it compatible with the new 1.17 LoadBalancer and LBFactory

Comment:

Every global must be initialised before it is read:
 +if( !isset( $wgSecurityUseDBHook ) ) $wgSecurityUseDBHook = false;

I'd also avoid file level code.

What is the point of assigning to variable which is never read?
 +$db = &wfGetDB( DB_SLAVE );


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to