User "Aaron Schulz" posted a comment on MediaWiki.r90722.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90722#c18669
Commit summary:

Release-note fixes

Summaries in release notes must describe either what has been done or what 
should be done, not (just) what "happens" or "happened". ie. "Setting $foo to 
true triggers Bar" is not very useful. "Do Lorem if $foo is true" or "Lorem is 
now done when $foo is true" is more useful.

(Also follows up on r88356 CR)

Comment:

"After the document is ready, mw.loader is broken..." is still not worded well. 
It makes it sound like you *broke* it now :)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to