User "Happy-melon" posted a comment on MediaWiki.r83909. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c18775 Commit summary:
Complete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist: * Move and rename to SpecialBlockList * Use an HTMLForm in GET mode for the options form * Use TablePager to organise the results more nicely * Standardise the filtration for IPs and IP ranges, so looking at blocks for a range will now also show rangeblocks which contain the range * General tidy up Comment: <blockquote><pre>+ $formatted = wfMessage( 'autoblockid', $row->ipb_id );</pre> How does that work? Should it return HTML? </blockquote> The <tt>Message</tt> class has a __toString() magic method. <blockquote><pre>+ static $headers = null;</pre> Why does getFieldNames() use a static var? Is it called often or something? </blockquote> Actually no, it's not. Doesn't do any ''harm'', per se, though. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
