User "Brion VIBBER" changed the status of MediaWiki.r83715. Old Status: new New Status: resolved
User "Brion VIBBER" also posted a comment on MediaWiki.r83715. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83715#c18815 Commit summary: Improve fetching of the donation amount, remove unecessary globals. * Add User-Agent header when accessing wikimediafoundation.org to prevent 403s * If remote information is for some reason unavailable, don't display the banner at all * Remove globals that are no longer used * Use $wgDBName as the default $wgCentralDBname for small wikis. Schema update will create tables in $wgDBName anyway. Comment: Looks ok, though there is a lot of additional code duplication added in r83744 which should be undone. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
