User "Happy-melon" changed the status of MediaWiki.r85288.

Old Status: fixme
New Status: reverted

User "Happy-melon" also posted a comment on MediaWiki.r85288.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85288#c18821
Commit summary:

Implement magic accessors for RequestContext variables: you can now just call 
$context->request->stuff(), and that is internally mapped to the get accessor.  
Rename the private variables to the old $mName syntax: I know that that's 
"discouraged in new code", but in this case it stops over-clever IDEs 
highlighting the magic accesses as potential visibility errors and sticking big 
error tags on them.

Comment:

I've reverted in r90899 what bits of this haven't already been overwritten by 
later changes.  

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to