User "Brion VIBBER" posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18834 Commit summary:
Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: Then you'll have to decide how to name them. :) Generally the purpose of defining an interface is to have a formal type that can be specified for parameter validation, type-ahead code suggestions etc without forcing all implementations to be based on a particular parent class. As such, the interface should probably be the default name form you'd be using everywhere -- like how we say 'Title' and 'Revision' and 'Preprocessor'. So here, I'd expect 'ContextSource' to be the interface. I'm not really sure I understand what this interface *and* abstract class are even for, if they just call through to an underlying Context object. Is this supposed to be like a semi-stub object where you might actually be loading up the Context object on demand? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
