User "Awjrichards" changed the status of Wikimedia.r205.

Old Status: new
New Status: fixme

User "Awjrichards" also posted a comment on Wikimedia.r205.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/205#c18894
Commit summary:

moving the contents of 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/fundraiser-statistics/fundraiser-scripts/
 for fundraiser analytics and reporting to the wikimedia repository

Comment:

<code>
/trunk/fundraiser-analysis/settings.py
</code>
You should generecize this file  - you don't want to be checking in login 
credentials or other sensitive configuration settings, even if they'll only 
work on your local machine.  It's bad practice.  One way to get around this is 
to create an 'example' config file - eg settings.py.example - where you have 
sample values for configuration directives.  Then, on whatever system you're 
running the code, you set up individual and local-only copies of the config 
file.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to