User "RussNelson" posted a comment on MediaWiki.r90747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90747#c18910 Commit summary:
getPath() does the wrong thing under SwiftMedia, but getRel() works for everything. Comment: Yes, it implicitly gets you a read-only copy of the file. I've audited all the (checked-in) code which calls File::getPath() and I see no problem with adding this semantic to it. There are *many* places where one piece of code or another expect the file to have local filesystem semantics. Fortunately, they all gateway through File::getPath(), so I think we can "refactor" by changing the API. We just say that people shouldn't expect File::getPath() to be lightweight on the first call. The copy is cached, so subsequent calls are lightweight. There's a LOT of duplicated code in SwiftFile which will be deleted on the checkin I'm about to do. Just reviewing the diff for sanity before I commit. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
