User "Nikerabbit" posted a comment on MediaWiki.r91063. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91063#c18930 Commit summary:
Added the CollabWatchlist extension. See http://www.mediawiki.org/wiki/Extension:CollaborativeWatchlist/de Comment: The code looks good overall. Some small notes: * Coding conventions recommend writing null in lowercase * It would of course be cool if core code would not need to be patched * $wgUser->getSkin() has been recently deprecated, but can still be used to achieve BC with older MW versions * In wlCountItems $db->selectField might be a convenient shortcut * while( $row = $res->fetchObject() ) can usually be replaced with foreach ( $res as row ) * In wlGetFilterClauseListUser it should be possible to use more database functions like ->makeList, or 'field!' => array() syntax supported in trunk *   should be replaced with  , although Xml::inputLabel and such might actually suit better in some cases * Maybe Exceptions should be replaced with MWExceptions? What is the intention of this code: + $title = Title::newFromText( $wgContLang->specialPage( $page ) ); If I understand it correctly you can use SpecialPage::getTitleFor( $page ) instead. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
