User "^demon" posted a comment on MediaWiki.r91065. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91065#c18941 Commit summary:
Vector: Add maintenance script to switch a preference for users with the noexperiments preference enabled. This is needed for the upcoming WikiLove deployment Comment: * You're calling begin() on every iteration, but only commit() when there are no more results? Just looks wrong :) * Also, use RUN_MAINTENANCE_IF_MAIN instead of DO_MAINTENANCE for good form. * Finally: is there a reason you're only changing the preference if the person is logged in? Maybe...couldn't tell immediately. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
