User "Bawolff" posted a comment on MediaWiki.r91059.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91059#c18944
Commit summary:

BacklinkCache was forgetting to check rd_interwiki when getting redirects, and 
thus getting
some extranous backlinks for the redirect table (if there happened to be a page 
redirecting
to an interwiki page with the same name plus an interwiki prefix).

Not a major issue since this is really only used as far as i can tell, to purge 
squids and html file cache.
A couple of extra unneeded purges shouldn't hurt anything, just a bit pointless.

Comment:

Since 1.16 - r69181

One thing, looking at r69181 just now it appears that the redirect table could 
have nulls in it during the time right after its added. I'm not sure if I 
should change the where condition to be rd_interwiki = '' or rd_interwiki is 
null? Or does it matter since the table was added three versions ago and old 
entries are updated on page view, so there really should not be any nulls 
left(?)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to