User "Nikerabbit" posted a comment on MediaWiki.r91159.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159#c19013
Commit summary:
Expand on r91123 Article refactoring:
* Added $user param to relevant WikiPage functions (with b/c)
* Cleaned up editUpdates() signature and tweaked three other WikiPage functions
signatures (with b/c)
* Added fixme to prepareTextForEdit()
Comment:
<pre>
+ public function commitRollback( $fromP, $summary, $bot,
&$resultDetails, User $guser = null ) {
global $wgUseRCPatrol, $wgUser, $wgContLang;
+ $guser = is_null( $guser ) ? $wgUser : $guser;
</pre>
I don't think adding automatic use of global $wgUser is good idea for new
params.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
