User "Aaron Schulz" changed the status of MediaWiki.r91180. Old Status: new New Status: fixme
User "Aaron Schulz" also posted a comment on MediaWiki.r91180. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91180#c19028 Commit summary: Fixes for r88113 and some realted changes: * Modified <s>Article::editUpdates()</s> WikiPage::doEditUpdates() arguments to take a Revision object, an User object and options (much more readable that those boolean parameters) * Call isCountable() on the old content and pass it to WikiPage::doEditUpdates() with the 'oldcountable' option so that it really reflects the old state of the page * Updated all calls (no one in extensions) and removed the wrapper WikiPage::editUpdates() * Call onArticleEdit() and onArticleCreate() (the one that is of course) from doEditUpdates() * Removed $wgTitle hack from Import.php Comment: <code>+ $user = User::newFromName( $revision->getRawUserText() );</code> You need to pass <false> into the second newFromName param or this will fail on IP users. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
