User "Jack Phoenix" posted a comment on MediaWiki.r90996. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90996#c19034 Commit summary:
Comment: I'd prefer if you used tabs instead of spaces consistently across the code. Right now, the first two lines and the last line of wfGetHistory use tabs, while the rest of the function uses spaces. Depending on your text editor, it should be relatively easy to set it to convert four spaces to one tab character. The JS should be (re)written to be object-oriented, just to avoid any problems with [[ResourceLoader]] (even though SocialProfile doesn't really support RL yet). See r91173 for an example where I converted UserBoard's BoardBlast.js to be more object-oriented. In UserStatusClass.php, you're adding a CSS file that does not (yet?) exist to the page output. I assume that you're planning to add the file eventually, so it's not such a big deal. As Nikerabbit mentioned above, messages should be prefixed with a key (I'd suggest <code>userstatus-</code>) to prevent conflict with core MediaWiki message. If you later on decide to change UserStatus' edit message from "Edit" to "Edit this status" (for example), it won't change the text of the edit tab on [[Sandbox|normal wiki pages]]. :-) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
