User "Awjrichards" changed the status of Wikimedia.r197. Old Status: new New Status: fixme
User "Awjrichards" also posted a comment on Wikimedia.r197. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/197#c19036 Commit summary: Adding my first PHPUnit test to the repo. This begins to address story 149 in the 2011 fundraiser. (Most of this won't quite work until I also commit my updates to stompPFPPendingProcessorSA.php). Comment: <pre> + $this->refreshConfig(array('activemq_stomp_uri' => 'CompleteNonsense')); </pre> :D <pre> + protected function setUp() { +// $this->object = new StompPFPPendingProcessorSA; + // set some configuration variables (for more info, check in PaypalIPNListener.php + $this->config_base = array ( + 'pfp_url' => 'https://payflowpro.paypal.com', + 'pfp_partner_id' => '', + 'pfp_vendor_id' => '', + 'pfp_user_id' => '', + 'pfp_password' => '', + 'activemq_stomp_uri' => 'tcp://localhost:61613', + 'activemq_pending_queue' => '/queue/test_donations', + 'activemq_confirmed_queue' => '/queue/test_confirmed', + 'batch_size' => 20, + 'log_level' => 2, + 'stomp_path' => '/var/www/civicrm/sites/all/modules/queue2civicrm/Stomp.php'); + + // instantaite the processor with our config options + $this->processor = new testPPPlogging($this->config_base); + } </pre> $this->config_base should not have hardcoded values where the values may not be the same from machine to machine (eg stomp_path, activemq_stomp_uri, etc) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
