User "Aaron Schulz" changed the status of MediaWiki.r83863. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r83863. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83863#c19074 Commit summary: Bug 2557: Sidebar items missing from classic, cologne blue, simple skins * Simple skin support multiple sidebar items * Standard (a.k.a. Classic) likes to add "my watchlist" and "my contributions" links at the bottom of the first sidebar box. It also has no titles for boxes. * Cologne blue supports multiple sidebar boxes with titles. Comment: I don't like the <code>$barnumber == 1</code> check in that it now assumes $bar always is not empty (otherwise the watchlist link won't get added). But that's unlikely and that skin isn't really supported much anyway, so it's tolerable. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
