User "Hashar" posted a comment on MediaWiki.r91270. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91270#c19110 Commit summary:
Merge ApiTestSetup into ApiTestCase and update all subclasses. The amount of duplication here was nasty, and also lets us get rid of a bunch of useless require_once()s. ./phpunit.php --filter Api currently gives me: Tests: 24, Assertions: 107, Incomplete: 1, Skipped: 2. Comment: This commit has issue on CruiseControl with messages like: Skipping numeric key X. In Unknown line 0. Where X is a number. According to some googling, it seems related to $_SESSION being passed a numeric key. To catch the issue, we would need to add a strack trace logging before any $_SESSION assignment and try to find the culprit. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
