User "DieBuche" changed the status of MediaWiki.r87032. Old Status: new New Status: ok
User "DieBuche" also posted a comment on MediaWiki.r87032. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87032#c19124 Commit summary: AFT JsPerf commit: * Use internal cached rootJQuery/$(document) * Using $.fn.insertBefore instead of $.fn.before (~ 40% faster (since one calls the other internally); also makes code more readable imho) * Appending events to #t-articlefeedback *before* appending it to the dom (also saves a find() query) * Not using 'mediaWiki' inside a ((mw){ })(mediaWiki) wrapper (!) * Removing the alias from the wrapper, mw is a global alias. * (more soon, commiting this for now) Comment: L~336: Why are you using end() when it's the last command anyway? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
