User "Siebrand" posted a comment on MediaWiki.r91344. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91344#c19125 Commit summary:
* Added generic Rev_List revision listing class and refactored RevDelete_List stuff to use it * Fixed bug in revdelete where all list Items where assumed to be of the same type (no longer holds since r87804). This was causing "Undefined property: stdClass::$rev_timestamp" errors for deleted revs. * Cleaned up RevisionDeleter::getRelationType() * Minor cleanups to SpecialRevisionDelete Comment: Seeing the the underscores in the class names looked odd to me, but checking autoloader.php I see that it is used more often. I think that the class names RevisionList and Rev_List may be confusing. Anything you can see that can be done to prevent that? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
