User "Jack Phoenix" posted a comment on MediaWiki.r91374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91374#c19136 Commit summary:
Reworked UserStatus.js to be object-oriented Comment: Awesome! :D There are some minor coding style issues, but those can easily be fixed later on, either manually or via the stylize.php script. The actual JS rewrite looks OK to me, but [http://jshint.com/ JSHint] suggests the following little tweaks: *wrap the if-else statement in UserStatus.useHistory inside braces *in UserStatus.openStatusHistory, use three equal signs to compare with null *in UserStatus.openStatusHistory, in the "if historyBlock is null" statement, don't prefix historyBlock with the var keyword since that variable is already declared *the last line, which closes the <code>var UserStatus = {</code> statement, should have a semicolon Please revert the change you committed to SocialProfile.php, though — I don't think that UserStatus is ready for production just yet. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
