User "Hashar" posted a comment on MediaWiki.r85322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85322#c19148 Commit summary:
Add the revision-info and revision-info-current messages directly to the page, don't stick them in the content sub; this adds unwanted extra CSS styling which screws with the margin and font size. Comment: This change the setOldSubtitle() method behaviour. Instead of setting a title, it adds to the ouput. The method name (setOldSubtitle) is thus misleading. Please consider MZMcBribe comment about adding the navigation bar above the <nowiki><h1 id="FirstHeading"></nowiki> thus outside of the article content and just below the js-message div. That will make more sens overall. I am going to revert r85322 and its follow up r90883, that will let us advance a bit on 1.18. Please reapply a patch on trunk :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
