User "Kaldari" changed the status of MediaWiki.r91389. Old Status: new New Status: ok
User "Kaldari" also posted a comment on MediaWiki.r91389. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91389#c19216 Commit summary: WikiLove fixes: * Follow-up r91083 CR: Make sure input like "image.jpg" or "File.jpg" will get a "File:" prefix as well. * Adding some caching in openDialog() for the current type (to avoid re-accessing a 3-levels-down object member) * Adding a check to make sure the "type" property is not "null" or "undefined" but actually a plain object. This allows hooks and/or local configurations to not only modify and add wikilove-types but also to allow renaming, moving and removing object types by setting a property to null or undefined. ** Previously this kind of modification: < [[MediaWiki:WikiLove.js]]: > $.wikiLoveOptions.types.food = null; .. triggered an exception (as well as the dialog not actually being opened.) < [[User_talk:Foo]] Click WikiLove icon: > Uncaught TypeError: Cannot read property 'icon' of null * Setting $wikiLoveLink in the scope of wikiLove.init scope directly * Passing JSHint now (when ignoring escapement of HTML-snippet) Comment: Looks good. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
