User "Aaron Schulz" changed the status of MediaWiki.r90585. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r90585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90585#c19223 Commit summary: * removed DEFAULT '' NOT NULL constraints as '' is internaly converted to NULL in Oracle and throws an error * fixed tableName handling doSchemaUpgrade17 (must be careful to avoid multiple tableName calls as names don't get taged in DDL mode) * exit/reenter DDL mode on updatelog inserts Comment: I hope no one joins on these tables and does an existence check by seeing if one of these fields is null. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
