User "Bawolff" posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19282 Commit summary:
Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: Most other calls to unserialize are wrapped in wfSuppressErrors anyways. If bad data ever got into the db (which should not happen), it would generate an E_NOTICE. I'd prefer to leave the error suppression in, but don't have strong opinions. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
