User "Nikerabbit" posted a comment on MediaWiki.r91776.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91776#c19377
Commit summary:
start special page for viewing archived content.
Comment:
Inclusion protector is not needed for files which only contain a class.
+if (!defined('MEDIAWIKI')) {
MediaWiki doesn't use title case in messages.
+ 'ViewArchive' => 'View Archive',
Was this intended?
- $this->outputHeader();
+ //$this->outputHeader();
Wouldn't isset() be better here:
+ if ( array_key_exists( 'subfolder_name', $wgArchiveLinksConfig ) ) {
If you just want the title of the special page you are in, you can just use
$this->getTitle(); Also, Html is usually written without all capitals.
+HTML::openElement( 'form', array( 'method' => 'get', 'action' =>
SpecialPage::getTitleFor( 'ViewArchive' )->getLocalUrl() ) ) .
Also, usually the action is given as $wgScript, and then hidden title value is
included in the form. This is that people which use the default style urls
example.com/foo/index.php?bar, where everything after question mark is dropped
out by the browser (at least in POST requests).
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
