User "Brion VIBBER" changed the status of MediaWiki.r91844. Old Status: new New Status: resolved
User "Brion VIBBER" also posted a comment on MediaWiki.r91844. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91844#c19442 Commit summary: Add test suite for jquery.byteLimit: - Tests to verify that the byteLength does not exceed the byteLimit when inserting more characters - Tests to verify that it doesn't prevent too early (ie. if limit is 10 and we insert 20 characters, there should be 10 characters in the input field). This test suite has exposed that the latter is currently broken. jquery.byteLimit is preventing characters to be added as soon as byteLength(currentValue) + 3 is more than the given limit. (Follows-up r86698, r91148) Comment: r91894 fixes another bug in the test cases; using the array operator to get a char from a string (<code>str[i]</code>) doesn't work in IE6 or IE 7, which caused the simulated keypress stuff to fail to update the field properly. Switching to <code>str.charAt(i)</code> fixes this right up! _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
