User "Krinkle" posted a comment on MediaWiki.r90186. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90186#c19607 Commit summary:
Minor fixed in ext.vector.simpleSearch * Aliasing jQuery to $ locally instead of implying global * Don't use "!=" for length comparison, it's loose (may cast to boolean instead of numeral, 0 == false) and slower than a strict comparison. * "size()" is the same number of characters than .length and returns exactly the same, saves a function call * $.isArray does not return boolean as in PHP, it's a jQuery function to account for browser compatibility (ie. indexOf), returns -1 if not found. * Removed mouseover/focus per r89950 CR * Replaced spaces with tabs * Passes JSHint Comment: Thanks, must've read too quickly. Fixed in r92190. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
