User "DieBuche" posted a comment on MediaWiki.r92288. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92288#c19674 Commit summary:
ajaxCategories fixes: * Partial revert of r92264. mw.ajaxCategories has nothing to do with mediawiki.util.init, moved into separate initiation module, only loaded when ajax categories is enabled. * Removing instantiation from the script. mw.ajaxCategories is now a public accessible constructor * Fix Uncaught ReferenceError: wgUserGroups is not defined ($wgLegacyJavaScriptGlobals = false;) * Renamimng stripIllegals() to clean(), adding '#' to the regex as those are not allowed either. * Combining var statements by separating them with comma's ( var foo, bar, baz; ) instead of "var foo; var bar; var baz;"svn up * Using dot.notation for objects instead of array-like['string'] keys * Whitespace conventions * Using inArray utility instead of indexOf (cross-browser support, mostly IE6) ** $.inArray uses Array.prototype.indexOf if available, otherwise fallback to a loop. mw.util.inArray is a wrapper around $.inArray to return a boolean value (since inArray/indexOf may return 0) * Don't use $( '#bodyContent' ) (skin specific) but mw.util.$content * Using mw.Title * Re-using helper functions from the outer-closure instead of re-declaring them privately for every instance again (performance!) Follows-up: r92112, r92151, r92264 Comment: Thanks for those :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
