User "Catrope" changed the status of MediaWiki.r80766. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r80766. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/80766#c19684 Commit summary: (bug 26809) Uploading files with multiple extensions where one of the extensions is blacklisted now gives the proper extension in the error message. Comment: <pre> + $msg->params( implode( $sep, $details['blacklistedExt'] ) ); </pre> Instead of imploding with the comma separator yourself, you should probably use <code>$wgLang->commaList()</code> where you duplicated part (but not all, there's a few differing details such as parsemag) of this logic from. Looks good to me otherwise, marking OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
