User "^demon" changed the status of MediaWiki.r92588. Old Status: new New Status: fixme
User "^demon" also posted a comment on MediaWiki.r92588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92588#c19801 Commit summary: Follow up r91419. A boolean attribute can be both the empty string and its name [http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attributes] We use the later since that's what xhtml1 required [http://www.w3.org/TR/xhtml1/#h-4.5]. Comment: Breaks tests: <pre> $ ./phpunit.php includes/HtmlTest.php PHPUnit 3.5.13 by Sebastian Bergmann. .F. Time: 0 seconds, Memory: 17.75Mb There was 1 failure: 1) HtmlTest::testExpandAttributesForBooleans Boolean attributes skip value output Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ - selected="selected" + selected="" /opt/local/apache2/htdocs/phase3/tests/phpunit/includes/HtmlTest.php:54 /opt/local/apache2/htdocs/phase3/tests/phpunit/MediaWikiTestCase.php:64 /opt/local/apache2/htdocs/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:20 /opt/local/apache2/htdocs/phase3/tests/phpunit/phpunit.php:60 FAILURES! Tests: 3, Assertions: 10, Failures: 1. </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
