User "Kaldari" posted a comment on MediaWiki.r91499.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91499#c19816
Commit summary:

another fix for old jQuery UI on live

Comment:

The icons are always 16px by 16px. Thus, if they appear on the left side of the 
button (primary), they should be flush left (left:0). If they appear on the 
right side of the button (secondary), they should be 16px from the right 
(right:16px).

The extra selectors are to make sure that all cases are treated the same. It 
may actually make sense to just condense these into 2 selectors 
(.ui-button-text-icon-primary and .ui-button-text-icon-secondary), but I was 
trying to keep the change as minimal as possible.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to