User "SPQRobin" posted a comment on MediaWiki.r92598. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92598#c19867 Commit summary:
$wgUploadNavigationUrl should be used for file redlinks if $wgUploadMissingFileUrl is not set. The first was used for this until the second was introduced in r69997 (1.17). According to the comments there it was broken in 1.16 but as far as I tested it worked in 1.16. In any case, the old behavior should be restored as most WMF wikis have set wgUploadNavigationUrl but not wgUploadMissingFileUrl. Comment: In my opinion it is superfluous to have to configure all wikis with UploadNavigationUrl also with UploadMissingFileUrl. It's better if it falls back, which was the old behavior, and which is more logical. Also, the docs @ mediawiki.org said it falls back, which was wrong and confusing for other people (I updated it). Could you explain what was broken in 1.16? I don't see it. (And why is this revision marked fixme?) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
