User "Khorn (WMF)" posted a comment on Wikimedia.r251. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/251#c19881 Commit summary:
Additional changes for card #184 Adds a configurable path for the stomp libraries Fixes logic error throwing a review tag add error Adds a verify and stage function to take care of all required fields (both actually required, and required to be some value by later code) Fixes the insert into contribution_tracking (was missing a single-quote) Changes the simpletest to only output E_ALL errors to cut down the noise in Drush. Comment: I'm making the change to the first comment in a followup commit. As for the second comment, that's actually precisely the behavior I intended: In the event that a blank [anything] was explicitly passed in, I feel like that should be taken seriously as the intended data. This was just to stop Drupal from complaining in the event that any of these keys came in completely unset. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
