User "Owyn" posted a comment on MediaWiki.r92605. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92605#c19885 Commit summary:
added missing null checks in callers of Revision::newNullRevision Comment: It returns null when the underlying database query finds no rows. It could happen if the page id does not exist or the current page revision is missing. I'm not sure what the root cause of THAT is though, possibly slave lag? Also, SpecialImport calls Article->updateRevisionOn() before the hook and localFile calls it after the hook . I suspect it should probably run the hook after the article is updated in both cases. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
