User "Khorn (WMF)" posted a comment on Wikimedia.r355. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/355#c19890 Commit summary:
followup r203 r251 r253 Takes some suggestions that came up in the code review process * In the testing boostratp file: Uses PATH_SEPARATOR instead of ":" * In our queue2civicrm module for drupal: Generates a drush and watchdog error for each missing required field in a message, instead of just the first failure found. * In our thank_you module for drupal: Checks to make sure the thankyou_date not only exists, but is numeric and nonzero before determining that a thank you message was already sent. Comment: Just to be consistent: Repeating from r354 "Oops. Not sure why my svn client broke this up into two separate commits, but this comment should be for both r354 and r355." _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
