User "Aaron Schulz" posted a comment on MediaWiki.r75341.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75341#c19938
Commit summary:
Start of bug 24853, killing off 'functional' parts of failfunction code. Seems
when the constructors start getting changed, it starts borking. Using this as a
point of reversion/stashing
Comment:
<pre>
- if ( $this->mFailFunction ) {
- # Legacy error handling method
- if ( !is_int( $this->mFailFunction ) ) {
- $ff = $this->mFailFunction;
- $ff( $this, $error );
- }
- } else {
- # New method
- throw new DBConnectionError( $this, $error );
- }
</pre>
I guess the places where $this->mFailFunction was set to 1 needed this.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview