User "Kaldari" changed the status of MediaWiki.r92825. Old Status: new New Status: ok
User "Kaldari" also posted a comment on MediaWiki.r92825. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92825#c19982 Commit summary: Fixing 'country2' handling in DonationInterface. We don't really support a country2 field, but for legacy reasons, it's possible that a country2 value will be passed into the form (when dealing with premium gifts eg t-shirts). To protect downstream processing of premium gift data, I left the coutnry2 field in - if however it is not present or is a 0-length string (also a possible scenario...) then the value gets sent to whatve the value for 'country' is. Comment: Looks fine. The ", ''" part is redundant I believe, but doesn't hurt anything. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
