User "Brion VIBBER" changed the status of MediaWiki.r86622.

Old Status: new
New Status: ok

User "Brion VIBBER" also posted a comment on MediaWiki.r86622.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86622#c20041
Commit summary:

(bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in 
the WikiEditor toolbar act on each line individually

* Reintroduce support for the splitlines argument in encapsulateSelection(). 
Was implemented by Adam Miller in r61493 but got lost somehow
* Add 'splitlines': true for the bullet list and numbered list buttons. The 
indent button already had it, so that part of r61493 did survive
* Copy options.pre and options.post to local pre and post variables instead of 
using (and modifying!) them directly all over the place

Comment:

Test cases added in r92923; splitlines looks ok for the bullet lists.

There is one basic failure in IE 6, which may need to be investigated further. 
No obvious problem with the actual selection, so it might be a problem with the 
getSelection func. (Not related to this commit, which updated the splitlines 
support.)


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to