User "Dantman" posted a comment on MediaWiki.r91654.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91654#c20143
Commit summary:

Put the OpenGraphMeta info into meta tags section of OutputPage. Makes it more 
portable (not all wikis do headItems the same).

Comment:

I think that code needs two tweaks before it's put into core:
* We need something that can be feature tested. Like the 
MW_SUPPORTS_PARSERFIRSTCALLINIT constant was added for testing. property: is 
just part of the string and if we just drop that in there is no way to tell if 
the feature is supported or not, so the extension will break pre-1.19
* property: is not "Open Graph" it's part of RDFa, should probably fix the 
comments before inclusion into core.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to