User "^demon" changed the status of MediaWiki.r92608. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92608#c0 Commit summary: Allow blocked sysops to view Special:Unblock Previously, trying to visit [[Special:Unblock]] while blocked would give an error, even if the user has the unblockself permission. I moved the permission check from execute() to right before the code that does the actual unblocking. This should probably be examined closely for security, since I'm not familiar with this code, although the impact of a bug would be small. I tested some simple cases manually and they all worked as expected: * Unblocking self works (as before) * Submitting the form fails unless you're trying to unblock yourself (as before) * GETting the page with any parameters works (previously failed unless the target was your own username) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
