User "Aaron Schulz" changed the status of MediaWiki.r92855. Old Status: new New Status: resolved
User "Aaron Schulz" also posted a comment on MediaWiki.r92855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92855#c20383 Commit summary: Reduce a bit the coupling between Skin and OutputPage: * Removed Skin::setupUserCss() and merged it in OutputPage::buildCssLinks() and OutputPage::buildCssLinksArray(), also removed its call from ApiParse.php * Moved Skin::userCanPreview() to OutputPage since two of the three calls to that function are made from there and the last one in SkinTemplate.php is in a somewhat deprecated function * Removed the Skin parameter from OutputPage::buildCssLinks(), OutputPage::getHeadScripts(), OutputPage::getBottomScripts() and OutputPage::makeResourceLoaderLink() since we now have a context Also made ApiParse.php call createContext() instead of create a new RequestContext manually and set its Title so so that it does not rely on $wgRequest and $wgTitle to get that member objects Comment: Seems OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
