User "^demon" changed the status of MediaWiki.r92563. Old Status: new New Status: resolved
User "^demon" also posted a comment on MediaWiki.r92563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92563#c20399 Commit summary: Expand the defines from JSTokenizer::__construct() placing them at the top of the file. This fixes the Notices that would be produced if several JSTokenizer were instantiated. jsminplus was added in r91591. Defines code was generated with: $js = new JSTokenizer(); foreach ($js->opTypeNames as $operand => $name) echo "define('OP_$name', '$operand');\n"; foreach ($js->keywords as $keyword) echo "define('KEYWORD_" . strtoupper($keyword) . "', '$keyword');\n"; Comment: With r93020, this is resolved. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
