User "Krinkle" posted a comment on MediaWiki.r91728.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91728#c20452
Commit summary:

Rewrite mwsuggest.js using j.ui.autocomplete. This gets rid of a lot of the 
little kinks of the previously implemenation: The suggestion list now contains 
regular anchors which can be openened in new indows or separate tabs. The 
carret doesn't jump around anymore when using the arrow keys to select an item. 
This should make it much easier to eventually merge Vectors simple search & 
mwsuggest.

Comment:

I'm not sure exactly, but from what I understood mwsuggest is a legacy script 
and new scripts should use <code>jquery.ui.autocomplete</code> or 
<code>jquery.suggestions</code>. Why is this script being further developed on 
? I would recommend leaving it as is and migrate usages to one of the jquery 
plugins and eventually deprecate/remove mwsuggest.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to