User "Wikinaut" changed the status of MediaWiki.r94031. Old Status: new New Status: fixme
User "Wikinaut" also posted a comment on MediaWiki.r94031. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94031#c20514 Commit summary: * Moved action=history to use an Action subclass * Removed obsolete aliases PageHistory and PageHistoryPager; unused * Maintained backward compatibility with HistoryPage; extensions using it will still work * Use local context instead of global variables * Removed calls to OutputPage::setPageTitleActionText() and OutputPage::setSyndicated(), the first one does nothing and the second one is overriden by the setFeedAppendQuery() call just below * Call Linker methods statically * Fixed bug where feedEmpty() was not called on empty history since casting a ResultWrapper object to boolean always returns true even when there's no row Comment: Your commit brakes all ( &action=history ) Page history function with: PHP Fatal error: Call to undefined method HistoryPager::getOutput() in /includes/actions/HistoryAction.php on line 373, referer: index.php/Special:RecentChanges _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
