User "Jeroen De Dauw" posted a comment on MediaWiki.r94100. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94100#c20532 Commit summary:
improved: hiding format controls, minor JS cleanup Comment: Some style remarks: * It's convention to use lowerCamelCase for variable names. So $ignoredAttribs instead of $ignoredattribs and $flipStyle instead of $flip_style. * "$ignoredattribs = array()" should always be an array, so it's nice to specify this in the function with "array $ignoredattribs = array()". Nice work though! :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
