User "Hashar" changed the status of MediaWiki.r93261. Old Status: new New Status: fixme
User "Hashar" also posted a comment on MediaWiki.r93261. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93261#c20556 Commit summary: Save css optimizations for modern css ( margin: 0 0 0 0 to margin: 0 etc.) Comment: I do like the following changes: - '0pt' to '0' - '0 0 0 0' and '0 0' to '0' - named color 'gainsboro' to hex #DCDCDC I do not like: A) - margin: 0 -1em 1em -1em; + margin: 0 -1em 1em; Three parameters? I am sure CSS has this covered but I will probably not remember that the second parameter covers both right and left. The four parameters format is way easier to read. B) Colors with six digits are easier to copy paste in a drawing software / color picker. C) '.3em' is barely readable. Keep it as '0.3em' which is obvious. I appreciate having someone willing to optimize / clean up our years old stylesheets. Still, please keep readability above optimizations hacks. In the long term, the code is easier to maintain and we probably do not care that much about saving a few bytes in CSS. Marking 'fixme' _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
